joinspec for join nodes

0 votes
asked Jan 11 in Wanted features by Jens (140 points)

Hi,

In a previous posting I was asking for a way to combine forks with decision nodes. "plantuml" even created a quick test version with that feature.

During that discussion, I already mentioned an alternative: joinspec. This also is a standard activitiy model feature, it looks like that:

The joinspec is the "{or}" label in the example. Would it be able to add that?

Regards,

Jens

 

1 Answer

0 votes
answered Jan 12 by plantuml (134,570 points)
Hi,

Yes, it will be possible to add that.

We are currently woking on that, but don't have enough time so please be patient :-)

A message will be posted here when ready.

Regards
commented Jan 12 by Jens (140 points)
Thank you for the quick answer! I will be patient ;-)
commented Jan 12 by Jens (140 points)
Hmm... maybe I'm not that patient after all ;-) Maybe I could help you implementing that feature. I understand the code is found at

https://sourceforge.net/p/plantuml/code/HEAD/tree/

Is there any other code? For example, I did not found any tests.
Is there a contribution guideline or something? Are you interested in contributions?
commented Jan 12 by plantuml (134,570 points)
Yes, this is the code. There is also a mirror on https://github.com/plantuml/plantuml

Unfortunately, the refactoring we have started is not committed yet, so doing modification by yourself is not really possible on the "new code".
However, we are close to finish, so patience is the only option :-)

We are open to contributions but we have no guide yet for this.
People who succeed to understand the code usually send patches by mail, or clone the github tree.

Another way of contribution is to suggest syntax/new feature like you've done.
Skeaking about this and to keep things as simple as possible, we envision to allow brackets after the "end fork" command,
so that you could have:

@startuml
start
fork
:action A;
fork again
:action B;
end fork {or}
stop
@enduml

What do you think about it ?
commented Jan 12 by Jens (140 points)
Syntax is great!

When you're done with the refactoring, let me know. If I would contribute source code, I would probably use git fork and pull request.
commented Jan 12 by plantuml (134,570 points)
Here is a beta https://dl.dropboxusercontent.com/u/13064071/plantuml.jar
that supports the syntax "end fork {or}"
Not widely tested, so feedback welcome!
...