How/where should I integrate C4 themes into the plantuml-stdlib

0 votes
asked Mar 14, 2023 in Question / help by kirchsth (5,860 points)

I plant to add themes to the C4-PlantUML stdlib too (details see C4-PlantUML #295)
How should I store in the https://github.com/plantuml/plantuml-stdlib/tree/master/C4 folder that I can be used similar to an include, e.g. like below. Or should I use another approach?

!theme  C4/C4_AC4SpecificTheme
!include <C4/C4_Component>

....

Thank you and best regards
Helmut

1 Answer

0 votes
answered Mar 15, 2023 by plantuml (295,000 points)
theme and stdlib are really managed differently.

If you want to provide a new theme, you can provide a PR to https://github.com/plantuml/plantuml/tree/master/themes

Does it help?
commented Mar 15, 2023 by kirchsth (5,860 points)
but my theme would be only useful in combination with the C4 stdlib, should we still bring it to the global themes?
commented Mar 15, 2023 by plantuml (295,000 points)
Yes, for now let's put everything in the global themes.
We'll see if we will improve this latter.
commented Mar 15, 2023 by kirchsth (5,860 points)
OK, I will check that all themes will start with C4_ prefix
commented Mar 15, 2023 by The-Lu (65,440 points)
But if it is some new themes it seems to be on the good place...

To see if we exclude it to the Theme Gallery... (because I don't know how to combine with C4 on the Theme Gallery)...
commented Mar 15, 2023 by kirchsth (5,860 points)

Another approach could be that it is stored in C4/themes and it is used like below, but I don't know if this could work at all

!theme  C4_AC4SpecificTheme from <C4/themes>
!include <C4/C4_Component>

commented Mar 15, 2023 by plantuml (295,000 points)

Another approach could be that it is stored in C4/themes and it is used like below, but I don't know if this could work at all

We probably will end up with a solution like this.

Could you open an issue about it? (having sub folders in themes) Either here or on github.

Thanks!

commented Mar 16, 2023 by kirchsth (5,860 points)
OK, I will do it as soon I have a first working theme checked in.
BR Helmut
...