Allow 'topurl' on all hyperlink or URL

0 votes
asked Mar 24 in Wanted features by The-Lu (19,980 points)

Hello PlantUML team,

From https://forum.plantuml.net/13179/how-the-skinparam-topurl-works-url-links

  • Could you allow 'topurl' on all URL?

i.e. Could you change:

Line#107 in URLBuilder.java

return new Url(full, nullnull);

should be

return new Url(withTopUrl(full)nullnull);

Thanks @Martin for point out on the code.

Then here is the summary of my tests:

Regards,
Th.

commented Mar 24 by The-Lu (19,980 points)

And on the same subject, and from: https://forum.plantuml.net/6128/link-url-for-file-is-not-working-properly-in-class-diagram?show=12669#a12669

KR,
Th.

1 Answer

0 votes
answered Mar 26 by plantuml (251,240 points)
We have completely rewritten the UrlBuilder class, so it should be really better now.

We also handle the 'file:' protocol for topurl.

However, we did not really test, so your feedback is welcome :-)
commented Mar 27 by The-Lu (19,980 points)

Thanks PlantUML,

1/ FYI, tested on chrome, on 'http://www.plantuml.com/plantuml/uml/' the links are now disabled? Why? We only show 'View Map Data'!


2/ Another question I dont understand this test (on line 140 of UrlBuilder):

if (url.startsWith("http:") == false && url.startsWith("https:") == false && topurl != null)

Because, with 'file:' this is OK, and this is without topurl even if this not on the line 140 test!

Regards,
Th.

...