Integrate *.ghe.com and custom rendering server in browser extension

0 votes
asked Sep 10 in Wanted features by Vincent D.
Dear team,

Thanks for your awesome project, we use it daily in our company.

I see you create a browser extension which is very nice but it doesn't work on github entreprise (ie. *.ghe.com).

Is it possible to integrate it with a custom rendering server url please ?
commented Sep 21 by Vincent D.
Any news or plan ?
commented 4 days ago by The-Lu (91,520 points)

Hello V,

  • Could you explain rapidly why: " it doesn't work on github entreprise (ie. *.ghe.com)"?
  • Or explain what is it specific on 'ghe' VS simple 'github.com'?
Similar to request for `Asciidoc` here:

Regards,
Th.

2 Answers

0 votes
answered 3 hours ago by The-Lu (91,520 points)
 
Best answer

Hello E.,

Thanks for the report. (And Thanks to PlantUML Team)

That will be now fixed on v0.3.3.

Regards,
Th.

0 votes
answered 3 days ago by Vincent D.

Hello The-Lu,

Thanks for your reply.

Regarding “it doesn’t work on GitHub Enterprise (i.e., *.ghe.com)”: the extension appears to be restricted to "https://github.com/*", so rendering is not triggered on URLs such as "https://<mycompany>.ghe.com/*".

This may be due to my configuration or enterprise policy, but I can’t seem to change the list of enabled sites.

As for the rendering server, that was my mistake. I thought rendering happened on plantuml.com, but after rereading the documentation, I understand that it runs in a local JavaScript engine

commented 2 days ago by The-Lu (91,520 points)

Hello V.,

Thanks for the report and the explanation.

That will be now fixed on the next release.

See:

Regards,
Th.

...