Skinparam from command line breaks salt diagrams

+1 vote
asked Oct 26, 2018 in Bug by syrdbaw4 (140 points)
edited Oct 26, 2018 by syrdbaw4

Cross-posting form https://github.com/qjebbs/vscode-plantuml/issues/164 as I suspet this may be a PlantUML issue, not a VSCode plugin issue.

I have the following diagram:

@startuml

salt

{

Just plain text

[This is my button]

() Unchecked radio

(X) Checked radio

[] Unchecked box

[X] Checked box

"Enter text here "

^This is a droplist^

}

@enduml

I also use a skinparam on the command line to work around the component diagram rendering bug:

-SfixCircleLabelOverlapping=true

Upon trying to render the diagram, I get the following error:

https://i.imgur.com/h5wdbJJ.png

I suspect the skinparam command line argument and salt syntax are not working well together here. I need to use the same PlantUML command for all rendering, so I cannot just use a different one for salt diagrams.

commented Oct 26, 2018 by albert (3,520 points)
Although I gave an answer based on the available code, I think an essential part in the example (the skinparmeter) is missing. Please specify the used skinparameter / commandline / ...
commented Oct 26, 2018 by syrdbaw4 (140 points)
I have edited the post to include the command line. Apologies for forgetting it!

Note: the same errors occurs if I try to use "version" with the skinparameter command line!
commented Oct 26, 2018 by albert (3,520 points)
With version it is logical. This is a special command and has to be the first command (as far as I know). A skinparameter with the version command does not make a lot of sense either (I think).
commented Oct 26, 2018 by syrdbaw4 (140 points)
I agree the skinparam does not make sense for all diagrams, such as version and others.

Of course, I am not going to customize my build script to give a separate command line arguments for each diagram, so this is a bit of a problem if I want to have a generic solution for building diagrams.
commented Oct 26, 2018 by albert (3,520 points)
From where dit you get the skinparameter: fixCircleLabelOverlapping as I ran plantulml with -language and in this list I don't see this skinparameter.
commented Oct 26, 2018 by plantuml (295,000 points)
This should be fixed with last beta http://beta.plantuml.net/plantuml.jar

As @albert says, the skinparam does not make sense with salt. So we simply ignore it in that case.

This is an indirect side effect coming from -SfixCircleLabelOverlapping=true

We agree that customizing build script would be a pain. We have also corrected this for "version" but we did not test it widely.

Please post here if you find other issues and thanks for the feeback!
commented Oct 26, 2018 by albert (3,520 points)
@plantuml has the list of skinparameters with -language also been updated? I still don't see it in the latest version (PlantUML version 1.2018.13beta3)
commented Oct 26, 2018 by albert (3,520 points)
@plantuml when using the -SfixCircleLabelOverlapping=true with the version 1.2018.13beta3 I still get an error message:
    Error line 1 in file: D:\...\aa.pu
    Some diagram description contains errors
commented Oct 26, 2018 by plantuml (295,000 points)
We did not test enough :-)
1.2018.13beta4 should be better http://beta.plantuml.net/plantuml.jar
skinparameters with -language has also been updated.
commented Oct 26, 2018 by albert (3,520 points)
Thanks, the example now works and I see the skinparameter in the list.
commented Nov 12, 2018 by syrdbaw4 (140 points)
Thank you for the fix @plantuml! I am very impressed by the speed of your responses!

Your answer

Your name to display (optional):
Privacy: Your email address will only be used for sending these notifications.
Anti-spam verification:

[Antispam2 Feature: please please wait 1 or 2 minutes (this message will disappear) before pressing the button otherwise it will fail](--------)
To avoid this verification in future, please log in or register.
...