specify fall back fonts is not working

Question

Hi,

based on https://forum.plantuml.net/10498/is-there-a-supported-way-to-specify-fall-back-fonts it should be possible to define multiple default fonts. But I think it is not working. I tried it with following

@startuml
skinparam title{
  Fontsize 50
}
title TestTitle

' not working
' skinparam DefaultFontName NotExisting, Courier
' working
skinparam DefaultFontName Courier

[Room] --> [Chair] : "has several"
@enduml

Did I oversee something?

Thank you and best regards
Helmut

Comments

I'm not a coder, but I'm suspicious of this block of code in UFont.java:

  private static Font buildFont(String fontFamily, int fontStyle, int fontSize) {
    if (fontFamily.contains(",")) {
      for (String name : fontFamily.split(",")) {
        name = StringUtils.eventuallyRemoveStartingAndEndingDoubleQuote(name).trim();
        if (doesFamilyExists(name)) {
          return new Font(fontFamily, fontStyle, fontSize);
        }
      }
    }
    return new Font(fontFamily, fontStyle, fontSize);
  }

In particular:

        if (doesFamilyExists(name)) {
          return new Font(fontFamily, fontStyle, fontSize);
        }

Surely if you're going to the trouble of checking that "name" is a font family, then it should return Font(name, fontstyle, fontsize) ?!

---

It could be that the problem is output format releated, eg. following works with svg but not with png

@startuml
skinparam TitleFontsize 50
title TestTitle

skinparam DefaultFontName NotExisting, Courier

[Room] --> [Chair] : "has several"
@enduml

With SVG it's working

With PNG it's not working 

Thank you and best regards
Helmut

 

---

Interesting.  That nearly blows my idea - unless the function should return "name" for png and  "fontFamily" for svg.

---

I found 2 better fonts that differences are more visible and added my test results.
@plantuml: can you please try Martins bugfix?

@startuml
' !$desc="valid (png) font name - (png) working"
' !$fontName="jlm_cmmi10"

' !$desc="valid (svg) font name - (svg) working"
' !$fontName="MS Gothic"

' !$desc="invalid and valid (png) font name - (png) not working"
' !$fontName="invalidFont, jlm_cmmi10"

' !$desc="invalid and valid (svg) font name - (svg) working"
' !$fontName="invalidFont, MS Gothic"

' !$desc="valid (png)+(svg) font name - (png) not working, (svg) working"
' !$fontName="jlm_cmmi10, MS Gothic"

!$desc="valid (svg)+(png) font name - (png) not working, (svg) working"
!$fontName="MS Gothic, jlm_cmmi10"

skinparam TitleFontSize 15

skinparam TitleFontName $fontName

Title "Test font settings << >> ? $ § [$desc] : $fontName
@enduml

E.g. last test output PNG

last test output SVG